Eric Sunshine <sunshine@xxxxxxxxxxxxxx> writes:
> On Mon, Oct 19, 2015 at 3:28 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote:
>> With the previous steps, it becomes clear that the mailinfo()
>> function is the only one that wants the "line" to be directly
>> touchable. Move it to the function scope of this function.
>>
>> Signed-off-by: Junio C Hamano <gitster@xxxxxxxxx>
>> ---
>> diff --git a/builtin/mailinfo.c b/builtin/mailinfo.c
>> index 12d1eda..c8dc73f 100644
>> --- a/builtin/mailinfo.c
>> +++ b/builtin/mailinfo.c
>> @@ -12,7 +12,6 @@ static FILE *cmitmsg, *patchfile, *fin, *fout;
>> static int keep_subject;
>> static int keep_non_patch_brackets_in_subject;
>> static const char *metainfo_charset;
>> -static struct strbuf line = STRBUF_INIT;
>> static struct strbuf name = STRBUF_INIT;
>> static struct strbuf email = STRBUF_INIT;
>> static char *message_id;
>> @@ -966,6 +965,8 @@ static void handle_info(void)
>> static int mailinfo(FILE *in, FILE *out, const char *msg, const char *patch)
>> {
>> int peek;
>> + struct strbuf line = STRBUF_INIT;
>
> Does there need to be a corresponding strbuf_release(&line) at the end
> of the function?
Indeed.
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html