On Sun, Oct 18, 2015 at 8:15 AM, Sidhant Sharma <tigerkid001@xxxxxxxxx> wrote:
> Mark <branch> optional in worktree command line usage to maintain consistency with man pages.
Thanks for the patch. To clarify that it is the in-code usage string
which is incorrect, rather than the man page, how about something like
the following as commit message instead?
worktree: usage: denote <branch> as optional with 'add'
Although 1eb07d8 (worktree: add: auto-vivify new branch when
<branch> is omitted, 2015-07-06) updated the documentation when
<branch> became optional, it neglected to update the in-code
usage message. Fix this oversight.
> Reported-by: ch3cooli@xxxxxxxxx
>
> Signed-off-by: Sidhant Sharma <tigerkid001@xxxxxxxxx>
Citing the reporter is a nice touch, but drop the blank line between
it and the sign-off.
> ---
> diff --git a/builtin/worktree.c b/builtin/worktree.c
> index 71bb770..33d2d37 100644
> --- a/builtin/worktree.c
> +++ b/builtin/worktree.c
> @@ -10,7 +10,7 @@
> #include "refs.h"
>
> static const char * const worktree_usage[] = {
> - N_("git worktree add [<options>] <path> <branch>"),
> + N_("git worktree add [<options>] <path> [<branch>]"),
> N_("git worktree prune [<options>]"),
> NULL
> };
> --
> 2.6.2
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html