Tobias Klauser <tklauser@xxxxxxxxxx> writes: > + * comments are considered contents to be removed or not. Returns the > + * number of lines in the resulting buffer. We write comments at imperative tone, hence "Return", not "Returns". Other than that, I agree with Junio: * A preparatory patch introducing parse-options would make the actual patch much easier to review. * Just running strbuf_stripspace and counting the number of lines in the result is much simpler. We use stripspace only on user-provided input which are never really big so maintainability is more important than performance. Cheers, -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html