On Tue, 2015-10-13 at 09:56 +0200, Michael Haggerty wrote:
> On 10/12/2015 11:51 PM, David Turner wrote:
> > From: Ronnie Sahlberg <sahlberg@xxxxxxxxxx>
> >
> > Add a ref structure for backend methods. Start by adding a method pointer
> > for the transaction commit function.
> >
> > Add a function set_refs_backend to switch between backends. The files
> > based backend is the default.
> >
> > Signed-off-by: Ronnie Sahlberg <sahlberg@xxxxxxxxxx>
> > Signed-off-by: David Turner <dturner@xxxxxxxxxxxxxxxx>
> > ---
> > refs-be-files.c | 10 ++++++++--
> > refs.c | 30 ++++++++++++++++++++++++++++++
> > refs.h | 15 +++++++++++++++
> > 3 files changed, 53 insertions(+), 2 deletions(-)
> >
> > [...]
> > diff --git a/refs.h b/refs.h
> > index 4940ae9..419abf4 100644
> > --- a/refs.h
> > +++ b/refs.h
> > @@ -619,4 +619,19 @@ extern int reflog_expire(const char *refname, const unsigned char *sha1,
> > reflog_expiry_cleanup_fn cleanup_fn,
> > void *policy_cb_data);
> >
> > +/* refs backends */
> > +typedef int ref_transaction_commit_fn(struct ref_transaction *transaction,
> > + struct strbuf *err);
> > +typedef void ref_transaction_free_fn(struct ref_transaction *transaction);
>
> The ref_transaction_free_fn typedef isn't used anywhere.
Will fix, thanks.
> > +struct ref_be {
> > + struct ref_be *next;
> > + const char *name;
> > + ref_transaction_commit_fn *transaction_commit;
> > +};
> > +
> > +
> > +extern struct ref_be refs_be_files;
>
> I don't think that refs_be_files is needed in the public interface.
We use refs_be_lmdb in a few other places to set up the lmdb backend, so
I thought I would put refs_be_files in refs.h too. But I can remove
refs_be_files and just stick it in the places it's needed.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html