Hi Junio, On 2015-10-12 22:28, Junio C Hamano wrote: > Johannes Schindelin <johannes.schindelin@xxxxxx> writes: > >>> I think the most sensible regression fix as the first step at this >>> point is to call it as a separate process, just like the code calls >>> "apply" as a separate process for each patch. Optimization can come >>> later when it is shown that it matters---we need to regain >>> correctness first. >> >> I fear that you might underestimate the finality of this "first >> step". If you reintroduce that separate process, not only is it a >> performance regression, but could we really realistically expect any >> further steps to happen after that? I do not think so. >> ... >> For the above reasons, I respectfully remain convinced that >> reintroducing the separate process would be a mistake. > > I am not saying we should forever do run_command() going forward. Fine, I will stop arguing about this and go back grumble in my corner. Ciao, Dscho -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html