On Fri, Oct 9, 2015 at 12:49 AM, Matthieu Moy
<Matthieu.Moy@xxxxxxxxxxxxxxx> wrote:
> Karthik Nayak <karthik.188@xxxxxxxxx> writes:
>
>> --- a/Documentation/git-for-each-ref.txt
>> +++ b/Documentation/git-for-each-ref.txt
>> @@ -134,9 +134,17 @@ align::
>> `<position>` is either left, right or middle, default being
>> left and `<width>` is the total length of the content with
>> alignment. If the contents length is more than the width then
>> - no alignment is performed. If used with '--quote' everything
>> - in between %(align:...) and %(end) is quoted, but if nested
>> - then only the topmost level performs quoting.
>> + no alignment is performed.
>> +
>> +if::
>> + Used as %(if)..%(then)..(%end) or %(if)..%(then)..%(else)..%(end).
>
> I guess you forgot to replace .. with ... (I think you agreed with me
> that it was better).
>
Oops! I missed this.
>> @@ -69,10 +72,16 @@ struct contents {
>> struct object_id oid;
>> };
>>
>> +struct if_then_else {
>> + unsigned int then_atom : 1,
>> + else_atom : 1,
>
> Maybe "then_atom_seen" and "else_atom_seen" would be better names. Or
> maybe they'd be too long, I leave it up to you.
>
They do describe the usage in a better way, so why not.
--
Regards,
Karthik Nayak
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html