Michael J Gruber venit, vidit, dixit 08.10.2015 10:15: > James McCoy venit, vidit, dixit 08.10.2015 07:01: ... > [No, this does not alleviate my dislike for the commit signature > implementation, and I have not checked the patch - the test looks good > to me, though.] OK, now grumpy ol' Mike actually tested the patch with all our tests that filter-branch something. All is good, and the new test catches the regression when run without the patch. I do think that the parser still has a problem that it had before already: it does not distinguish between an empty line and an all white space line (or else we didn't have a problem here at all). In that sense, the patch is wrong, it does not correct the parser deficiency. But it alleviates it for the special case of embedded signatures, which currently is the only exceptional case that I am aware of. It's not guaranteed to stay like that, of course. So maybe, one should amend the commit message by saying that. Michael -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html