Re: [PATCH v2 43/43] refs: tests for db backend

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2015-10-05 at 09:56 -0700, Junio C Hamano wrote:
> Dennis Kaarsemaker <dennis@xxxxxxxxxxxxxxx> writes:
> 
> > On Mon, Sep 28, 2015 at 06:02:18PM -0400, David Turner wrote:
> >> Add tests for the database backend.
> >> 
> >> Signed-off-by: David Turner <dturner@xxxxxxxxxxxxxxxx>
> >> ---
> >>  t/t1460-refs-be-db.sh        | 1103 ++++++++++++++++++++++++++++++++++++++++++
> >>  t/t1470-refs-be-db-reflog.sh |  353 ++++++++++++++
> >>  2 files changed, 1456 insertions(+)
> >>  create mode 100755 t/t1460-refs-be-db.sh
> >>  create mode 100755 t/t1470-refs-be-db-reflog.sh
> >
> > These break 'make test' on builds without the db backend. Maybe squash
> > in something like the following:
> >
> > diff --git a/t/t1460-refs-be-db.sh b/t/t1460-refs-be-db.sh
> > index f13b0f0..c8222ed 100755
> > --- a/t/t1460-refs-be-db.sh
> > +++ b/t/t1460-refs-be-db.sh
> > @@ -9,6 +9,11 @@ test_description='Test lmdb refs backend'
> >  TEST_NO_CREATE_REPO=1
> >  . ./test-lib.sh
> >  
> > +if ! test -e ../../test-refs-be-lmdb; then
> > +	skip_all="Skipping lmdb refs backend tests, lmdb backend not built"
> > +	test_done
> > +fi
> 
> The idea is sound, but $TRASH_DIRECTORY (i.e. $(cwd) there) is not
> necessarily two subdirectories down from the build repository root
> (cf. --root=<there> parameter to the test scripts), so you need to
> account for that.

will fix these, thanks Dennis and Junio.



--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]