Re: [PATCH v2 02/43] refs: make repack_without_refs and is_branch public

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2015-10-05 at 06:34 +0200, Michael Haggerty wrote:
> On 09/29/2015 12:01 AM, David Turner wrote:
> > Signed-off-by: Ronnie Sahlberg <sahlberg@xxxxxxxxxx>
> > Signed-off-by: David Turner <dturner@xxxxxxxxxxxxxxxx>
> > ---
> >  refs.c |  9 +--------
> >  refs.h | 13 +++++++++++++
> >  2 files changed, 14 insertions(+), 8 deletions(-)
> > 
> > diff --git a/refs.c b/refs.c
> > index ce551e9..2741cc5 100644
> > --- a/refs.c
> > +++ b/refs.c
> > @@ -2826,14 +2826,7 @@ int pack_refs(unsigned int flags)
> >  	return 0;
> >  }
> >  
> > -/*
> > - * Rewrite the packed-refs file, omitting any refs listed in
> > - * 'refnames'. On error, leave packed-refs unchanged, write an error
> > - * message to 'err', and return a nonzero value.
> > - *
> > - * The refs in 'refnames' needn't be sorted. `err` must not be NULL.
> > - */
> > -static int repack_without_refs(struct string_list *refnames, struct strbuf *err)
> > +int repack_without_refs(struct string_list *refnames, struct strbuf *err)
> 
> I looked for the corresponding change to remove `static` from
> is_branch(). Apparently that function already had external linkage, even
> though it was not listed in the header file. As a convenience to readers
> you might note that peculiarity in the commit message.

Will fix, thnaks.


--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]