Re: [PATCH 6/9] ref-filter: introduce format_ref_array_item()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Karthik Nayak <karthik.188@xxxxxxxxx> writes:

> The problem is with colors which tag.c doesn't use by default.
> Here we need to print colors only if we're printing to a tty which supports
> colors.

Ah, and tag --format '%(color:...)' does not do the tty autodetection.

> which does not play well with the implementation of --column as done
> in tag.c. Where, If I'm not wrong the --column option captures all
> output, formats it and then prints it to stdout. Hence when using
> colors, we're told that the printing isn't done to a tty which
> supports colors, hence we lose out on colors.

What I don't understand is how --column is different from --no-column
wrt colors.

In any case, this should be explained better in comments.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]