On Wed, Sep 30, 2015 at 01:00:56PM -0700, Junio C Hamano wrote: > > Wow, my patch isn't even close to reasonable. I didn't realize because > > we do not compile this code at all for non-Mac platforms. Sorry. > > Perhaps the way we completely stub out the platform specific helpers > contributes to this kind of gotchas? I am wondering how much additional > safety we would gain if we start doing something like this. I think it is an improvement, but it does not solve all of the problems. I also botched the implementation of probe_utf8_pathname_composition, and that does not get compiled on most platforms (though we _could_ compile it and just never call it). -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html