Junio C Hamano <gitster@xxxxxxxxx> writes: > + pick|p|drop|d|reword|r|edit|e|squash|s|fixup|f) > + if ! check_commit_sha "${rest%% *}" "$lineno" "$1" This does not pass my "tabs" test, as it parses the sha1 out of the line assuming it's separated with a space. It's used in other places of the code, but tabs still seem to work more or less by chance (they are not parsed properly by transform_todo_ids, but then they are understood by do_next). I changed it to while read -r command sha1 rest which is a bit more lazy. -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html