On Fri, Sep 25, 2015 at 9:30 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Matthieu Moy <Matthieu.Moy@xxxxxxxxxxxxxxx> writes: > >> Karthik Nayak <karthik.188@xxxxxxxxx> writes: >> >>> Remove the error "branch '%s' does not point at a commit" in >>> apppend_ref() which reports branch refs which do not point to >>> commits. Also remove the error "some refs could not be read" in >>> print_ref_list() which is triggered as a consequence of the first >>> error. >>> >>> This seems to be the wrong codepath whose purpose is not to diagnose >>> and report a repository corruption. If we care about such a repository >>> corruption, we should report it from fsck instead. >> >> (We actually already report it from fsck indeed) >> >>> This also helps in a smooth port of branch.c to use ref-filter APIs >>> over the following patches. On the other hand, ref-filter ignores refs >>> which do not point at commits silently. >> >> Seems much better. Thanks, > > Yes, it seems that I can just replace 5/8 with this and the > remainder can stay as they are. > > While I was trying to address your "actually already report", I > spotted a typo and then found that the early part of the second > paragraph is a bit hard, so here is what I ended up with. > > branch: drop non-commit error reporting > > Remove the error "branch '%s' does not point at a commit" in > append_ref(), which reports branch refs which do not point to > commits. Also remove the error "some refs could not be read" in > print_ref_list() which is triggered as a consequence of the first > error. > > The purpose of these codepaths is not to diagnose and report a > repository corruption. If we care about such a corruption, we > should report it from fsck instead, which we already do. > > This also helps in a smooth port of branch.c to use ref-filter APIs > over the following patches. On the other hand, ref-filter ignores refs > which do not point at commits silently. > > Based-on-patch-by: Jeff King <peff@xxxxxxxx> > Helped-by: Junio C Hamano <gitster@xxxxxxxxx> > Mentored-by: Christian Couder <christian.couder@xxxxxxxxx> > Mentored-by: Matthieu Moy <matthieu.moy@xxxxxxxxxxxxxxx> > Signed-off-by: Karthik Nayak <karthik.188@xxxxxxxxx> > Signed-off-by: Junio C Hamano <gitster@xxxxxxxxx> > > Thanks. Looks good to me, thanks :) -- Regards, Karthik Nayak -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html