On Thu, Sep 24, 2015 at 5:08 PM, Jeff King <peff@xxxxxxxx> wrote: > In some cases where we strcpy() the result of sha1_to_hex(), > there's no need; the result goes directly into a printf > statement, and we can simply pass the return value from > sha1_to_hex() directly. > > When this code was originally written, sha1_to_hex used a > single buffer, and it was not safe to use it twice within a > single expression. That changed as of dcb3450 (sha1_to_hex() > usage cleanup, 2006-05-03), but this code ewas never s/ewas/was/ > updated. > > History-dug-by: Eric Sunshine <sunshine@xxxxxxxxxxxxxx> > Signed-off-by: Jeff King <peff@xxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html