Re: [PATCHv3 02/13] xread: poll on non blocking fds

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Stefan Beller <sbeller@xxxxxxxxxx> writes:

> We should not care if the call to poll failed, as we're in an infinite loop and
> can only get out with the correct read(..).

I think I agree with that reasoning.  The only thing we want out of
this call to poll(2) is to delay calling read(2) again when we know
we would get EAGAIN again; whether the reason why poll(2) returned
is because of some error or because some data has become ready on
the file descriptor, we no longer are in that "we know we would get
EAGAIN" situation and do want to call read(2), which would return
either the right error or perform a successful read to make some
progress.

Sounds sensible.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]