On Mon, Sep 21, 2015 at 10:09:52AM -0700, Junio C Hamano wrote: > I think I said this already, but I found these bits from your patch > > - $(LIBS) $(CURL_LIBCURL) $(EXPAT_LIBEXPAT) > + $(CURL_LIBCURL) $(EXPAT_LIBEXPAT) $(LIBS) > > that first uses libcurl and then libs (which has ssl bits) totally > sensible. Shouldn't that be sufficient? That is not sufficient on its own because -lssl is not added in $(LIBS), it is only added in $(CURL_LIBCURL) if NEEDS_SSL_WITH_CURL is set. > > > The proper variable I should have used is > > NEEDS_SSL_WITH_CURL. But this variable is not setted on Linux and not > > configurable,... > > Really? Anything is configurable from your config.mak, I would have > thought. You right using the parts you find sensible and adding "NEEDS_SSL_WITH_CURL=YesPlease" in config.mak makes git compile fine. So I will resubmit with only the sensible part of the patch. I have one last question thought. Wouldn't it be nice if we had configure to autodetect the need for -lssl with libcurl ? We could make configure to check for Curl_ssl_init function symbol in libcurl, which is only present if libcurl has been compiled with openssl support, by adding something like that in configure.ac: AC_CHECK_LIB([curl], [Curl_ssl_init], [NEEDS_SSL_WITH_CURL=YesPlease], [NEEDS_SSL_WITH_CURL=]) The thing that I'm afraid of is that checking a function that is not part of official libcurl API could be not very reliable, don't you think ? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html