Re: [PATCH v5 0/8] port the filtering part of branch.c to use ref-filter APIs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Karthik Nayak <karthik.188@xxxxxxxxx> writes:

> --- a/t/t3203-branch-output.sh
> +++ b/t/t3203-branch-output.sh
> @@ -145,8 +145,8 @@ EOF
>  
>  test_expect_success 'git branch `--sort` option' '
>  	cat >expect <<-\EOF &&
> -	* (HEAD detached from fromtag)
>  	  branch-two
> +	* (HEAD detached from fromtag)
>  	  branch-one
>  	  master
>  	EOF

I thought this was obviously wrong, but this tests uses
--sort=objectsize, so it's OK. Indeed, HEAD and branch-one have
objectsize=215, and branch-two has objectsize=167.

So, the previous code was hardcoding "detached HEAD always comes first",
but we now sort the whole list, including detached HEAD, so branch-two
comes first.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]