On Fri, Sep 18, 2015 at 02:43:56PM -0400, Eric Sunshine wrote: > On Tue, Sep 15, 2015 at 12:10 PM, Jeff King <peff@xxxxxxxx> wrote: > > To generate "--keep=receive-pack $pid on $host", we write > > progressively into a single buffer, which requires keeping > > track of how much we've written so far. But since the result > > is destined to go into our argv array, we can simply use > > argv_array_pushf. > > > > Unfortunately we still have to have a static buffer for the > > s/static/fixed-size/ maybe? Thanks, will change. The term "static buffer overflow" seems stuck in my head (and you can find references via google), even though it does not make sense at all. In C terms, a stack buffer is really an "auto", but I guess "auto buffer overflow" does not have as nice a ring to it. I agree that "fixed-size" is a lot less confusing, and corrected several such cases before sent out the series. I guess I missed one (I'll grep for others). -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html