Re: [PATCH v17 14/14] tag.c: implement '--merged' and '--no-merged' options

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Junio C Hamano <gitster@xxxxxxxxx> writes:

> John Keeping <john@xxxxxxxxxxxxx> writes:
>
>>> +--[no-]merged [<commit>]::
>>
>> We prefer to write --[no-]* as:
>>
>> 	--option::
>> 	--no-option::
>>
>> although this may be the first instance that we see this combination
>> with an argument.
>>
>> I also found the "[<commit>]" syntax confusing and had to go and figure
>> out what PARSE_OPT_LASTARG_DEFAULT does; I wonder if it's worth
>> appending something like the following to the help for this option:
>>
>> 	The `commit` may be omitted if this is the final argument.
>
> "may be omitted" must be followed by a description of what happens
> when omitted (i.e. "defaults to ...").

Then:

The `commit` may be omitted and defaults to HEAD if this is the final
argument.

Sounds good to me.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]