On Wed, Sep 16, 2015 at 11:43:49AM -0700, Junio C Hamano wrote:
> Jeff King <peff@xxxxxxxx> writes:
>
> > + alloc = path_len + strlen(".pack") + 1;
> > + p = alloc_packed_git(alloc);
> > + memcpy(p->pack_name, path, path_len); /* NUL from zero-ed struct */
>
> This comment is confusing, isn't it? Yes, there is a NUL, but you
> will going to overwrite it with "." in ".keep" immediately and more
> importantly, that overwriting does not depend on NUL being there.
Yeah, you're right. I was blindly making sure that the behavior did not
change from the original, without noticing that the original did not
care about the NUL either way.
> What's more important to comment on would probably be the line that
> computes the "alloc". It uses ".pack" but that is because it knows
> that is the longest suffix we care about, and that deserves mention
> more than the NUL termination of intermediate result that does not
> matter, no?
Agreed. I'll add a comment to that effect.
-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html