On Wed, Sep 16, 2015 at 02:05:40PM +0200, Lars Schneider wrote: > On 16 Sep 2015, at 10:36, Luke Diamand <luke@xxxxxxxxxxx> wrote: > > On 14/09/15 14:26, larsxschneider@xxxxxxxxx wrote: > >> +test_file_in_mock () { > >> + FILE="$1" > > Missing && > > Plus the next few lines > Are they strictly necessary? I believe you can define variables all > in ?one line?. I found it like that in existing tests: The reason for keeping the &&-chain intact even on these variable assignment lines is to future-proof it against some programmer coming along and inserting new code above or in between the assignment lines, and not realizing that the &&-chain is not intact. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html