Hi Junio, Jeff & Ramsay, On 2015-09-16 03:32, Junio C Hamano wrote: > Jeff King <peff@xxxxxxxx> writes: > >>> Hmm, I haven't read any other patches yet (including those which use these >>> new '_to' functions), but I can't help feeling they should be named something >>> like 'sha1_to_hex_str()' and 'find_unique_abbrev_str()' instead. i.e. I don't get >>> the '_to' thing - not that I'm any good at naming things ... >> >> I meant it as a contrast with their original. sha1_to_hex() formats into >> an internal buffer and returns it. But sha1_to_hex_to() formats "to" a >> buffer of your choice. > > I think that naming makes perfect sense. I have to admit that I needed the explanation. Maybe we should stick to the established practice of the many, many reentrant POSIX functions following the *_r() naming convention? I.e. the reentrant version of localtime() is called localtime_r(), the reentrant version of random() is called random_r() etc. So I could see myself not needing an explanation if I had read sha1_to_hex_r(...). Ciao, Dscho -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html