Matthias Lederhofer <matled@xxxxxxx> writes: > Matthias Lederhofer <matled@xxxxxxx> wrote: >> Matthias Lederhofer <matled@xxxxxxx> wrote: >> > + inside_working_tree = !prefixcmp(cwd, worktree); >> [..] >> > + inside_git_dir = !prefixcmp(cwd, gitdir); >> >> This time a real bug: the parameters have to be the other way around. > > Sorry, it was right. prefixcmp got me confused again when doing some > testing and the result wasn't what I expected. I'll go and copy&paste > 100 times !prefixcmp(str, prefix) means "begins str with prefix?" I do not mind replacing the whole set, but keeping track of these small "oops", "oh", "ah" are confusing to me. Could you take a deep breath, review them yourself one more time, and resend, *after* making sure that you are confident with them enough to feel that you would not have to issue "oops", "sorry", "ah this is better" messages for a few days after sending them out, pretty please? - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html