On Sun, Sep 13, 2015 at 5:45 PM, Matthieu Moy <Matthieu.Moy@xxxxxxxxxxxxxxx> wrote: > Karthik Nayak <karthik.188@xxxxxxxxx> writes: > >> We check if given ref is the current branch in print_ref_list(). Move >> this check to print_ref_item() where it is checked right before >> printing. > > You may want to add a sentence saying why this is good. Given the > context, it's relatively clear that this makes the code closer to the > shape expected by ref-filter, but if you imagine someone bisecting or > blaming and finding this commit in another context, that person may > appreciate more explanation. > Will do. -- Regards, Karthik Nayak -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html