On Sat, Sep 12, 2015 at 2:44 PM, Matthieu Moy <Matthieu.Moy@xxxxxxxxxxxxxxx> wrote: > Karthik Nayak <karthik.188@xxxxxxxxx> writes: > >> On Thu, Sep 10, 2015 at 10:27 PM, Matthieu Moy >> <Matthieu.Moy@xxxxxxxxxxxxxxx> wrote: >>> Karthik Nayak <karthik.188@xxxxxxxxx> writes: >>> >>>> This is part of the series of unifying the code used by >>>> "git tag -l, git branch -l, git for-each-ref". >>>> >>>> The previous version can be found here (version 16): >>>> article.gmane.org/gmane.comp.version-control.git/277394 >>>> >>>> Changes in this version: >>>> * The arguments of the %(align) atom are interchangeable. >>>> * Small grammatical changes. >>>> * Small changes in the tests to reflect changes in the align >>>> atom code. >>> >>> Clearly, we're almost there. I did a few minor remarks. I suggest >>> (admitedly, Eric suggested of-list to suggest ;-) ) that you reply to >>> them by re-sending only individual patches that changed (replying to the >>> original patch) so that we can check the new patches individually. I >>> think we can do the finishing touches for each patch in a subthread of >>> this patch. >>> >> >> I replied with suggested changes by you and Junio. >> Let me know if any other changes to be made :) > > I went through the patches you resent, it all looks good to me. > > If I read correctly, Junio already applied it to pu. I'll push the next set of patches then. -- Regards, Karthik Nayak -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html