Karthik Nayak <karthik.188@xxxxxxxxx> writes: > + /* > + * TODO: Implement a function similar to strbuf_split_str() > + * which would omit the separator from the end of each value. > + */ > + s = to_free = strbuf_split_str(valp, ',', 0); > + > + align->position = ALIGN_LEFT; > + > + while (*s) { > + if (s[1]) A comment like /* strip trailing ',' */ here would really help the reader IMHO. > + strbuf_setlen(s[0], s[0]->len - 1); -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html