Re: [PATCH v16 00/14] port tag.c to use ref-filter APIs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Ehh, I was only kidding, though...

On Wed, Sep 9, 2015 at 10:37 AM, Karthik Nayak <karthik.188@xxxxxxxxx> wrote:
> On Tue, Sep 8, 2015 at 11:50 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote:
>> Matthieu Moy <Matthieu.Moy@xxxxxxxxxxxxxxx> writes:
>>
>>>>> This line still looks overlong.  Would it help to stop spelling this
>>>>> as a double "a = b = overlong expression" assignment?
>>>>>
>>>>
>>>> I'm not sure, I get what you mean.
>>>
>>> I guess
>>>
>>> format = xstrfmt("%%(align:15,left)%%(refname:short)%%(end) %%(contents:lines=%d)",
>>>                  filter->lines);
>>> to_free = format;
>>>
>>> (still 83 columns + indentation, but that's a bit shorter than your
>>> version).
>>
>> Sure.  This may also be possible
>>
>>         xstrfmt("%s %%(contents:lines=%d)",
>>                 "%(align:15,left)%(refname:short)%(end)", filter->lines);
>>
>> and highlights that the only thing that is variable is the number
>> of lines, which might be better.
>
> Yeah looks better, thanks.
>
> --
> Regards,
> Karthik Nayak
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]