Re: [PATCH v3 00/11] Make "local" orthogonal to date format

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Sep 03, 2015 at 10:48:50PM +0100, John Keeping wrote:

> Since version 2 there are four new preparatory patches which remove
> lists of date formats from documentation in favour of referring to the
> detailed list in git-rev-list(1) or git-log(1) (both generated from
> Documentation/rev-list-options.txt) depending on whether the page in
> question is plumbing/porcelain.

This version looks good to me. It turned out to be a bigger job than we
expected at first; thanks for seeing it through.

> In patch 7 (date: check for "local" before anything else), we no longer
> reject "relative-local" and "raw-local" now prints the user's local
> timezone offset.  The error message for invalid formats that are
> prefixed with a valid format name is now the same as that if there is no
> valid prefix.

That sounds OK. We have enough information in our parsing state to say
"I understood the 'iso8601', but '-foobar' did not make any sense to
me". But it's doubtful that would ever come up in practice.

-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]