On 7 September 2015 at 13:21, <larsxschneider@xxxxxxxxx> wrote: > From: Lars Schneider <larsxschneider@xxxxxxxxx> > > One thing I don't like about the current implementation is that I don't see a > way to test the "git-p4.pushLargeFiles" config. I could start a git lfs server > locally but that seems a bit too much, no? Perhaps add a trivial large-file derived class that just does enough to show that it's all working. Then the final bit of pushing the large files to LFS would remain forever untested, but it would be small enough and simple enough not to be a real problem. If it ever broke, it would indicate that either the trivial test class was a bit too trivial, or that the abstraction was not abstract enough and there's too much common-code in the derived classes. Luke -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html