Junio C Hamano <gitster@xxxxxxxxx> writes: > Johannes Sixt <j6t@xxxxxxxx> writes: > >> Why do we need a new rule? The old git-am had a logic that pleased >> everyone, and it must have been implemented somewhere. Shouldn't it be >> sufficient to just re-implement or re-use that logic? > ... > Perhaps we would need to tell has_conforming_footer() function who > the caller is, and use a different logic (i.e. "just re-implement") > when the caller is append_signoff(). Ah, I think I misunderstood you. "just re-implement" could be "not to use the existing helper used by other callers and instead do it manually all inside builtin/am.c", and I agree that it would be the safest way to go. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html