Josh Rabinowitz <joshr@xxxxxxxxx> writes: > Hi Junio and other recipients: > > Junio, thanks for your response. I think you may have misunderstood my > patch though (or I am misunderstanding your responses), because it > seems we are actually in agreement. > > 1) My original patch is to make 'git push --porcelain --quiet' not > emit 'Done' when there is no error. It would continue to emit "Done" > when using 'git push --porcelain' without an error. > > 2) In your first paragraph, you seem to state that while printing > "Done" is advantageous when using 'git push --porcelain' without > --quiet, the "Done" output isn't needed when --quiet is used. This > appears to agree with my patch's intent. > > 3) in your second paragraph, you seem to agree with me again, that > "Done" is not needed when "git push --porcelain --quiet" is use > > 4) Then in your third paragraph, you say that you don't want to remove > the "Done" output when using "git push --porcelain" without --quiet -- > which my patch preserves (again, it would only remove the "Done" text > when 'git push --porcelain' is used with --quiet and there is no > error.) > > In summary, I think we are in agreement that this patch is probably > acceptable. Look forward to reading comments. I think your 4. misinterprets what I meant to say. Even if we agree 1 thru 3, changing the output, with or without "--quiet", is an unwelcome thing to do to existing scripts. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html