Re: [PATCH v5] git-p4: add config git-p4.pathEncoding

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Lars Schneider <larsxschneider@xxxxxxxxx> writes:

> > Hi Lars,
> >
> > Lars Schneider <larsxschneider@xxxxxxxxx> writes:
> >
> >> +test_expect_success 'Clone repo containing iso8859-1 encoded paths with git-p4.pathEncoding' '
> >> +
> >> +        test_when_finished cleanup_git &&
> >> +        (
> >> +                cd "$git" &&
> >> +                git init . &&
> >> +                git config git-p4.pathEncoding iso8859-1 &&
> >
> > Wouldn't 'test_config' be better here?
> >
> If I got Eric’s explanation right in "[PATCH v1] t9821: use
> test_config” then we should not use “test_config” here?

After reading Eric's point of view, I agree with him about this.

So, sorry for the noise, now I'll know better in the future when
to use and not use 'test_config'.

Thanks,
Rémi
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]