On 03 Sep 2015, at 21:57, Luke Diamand <luke@xxxxxxxxxxx> wrote: > On 03/09/15 17:35, larsxschneider@xxxxxxxxx wrote: >> From: Lars Schneider <larsxschneider@xxxxxxxxx> >> > > Explanation? Add a git config reader for integer variables. Please note that the git config implementation automatically supports k, m, and g suffixes. OK? > >> Signed-off-by: Lars Schneider <larsxschneider@xxxxxxxxx> >> --- >> git-p4.py | 11 +++++++++++ >> 1 file changed, 11 insertions(+) >> >> diff --git a/git-p4.py b/git-p4.py >> index c139cab..ae1a4d3 100755 >> --- a/git-p4.py >> +++ b/git-p4.py >> @@ -623,6 +623,17 @@ def gitConfigBool(key): >> _gitConfig[key] = gitConfig(key, '--bool') == "true" >> return _gitConfig[key] >> >> +def gitConfigInt(key): >> + if not _gitConfig.has_key(key): >> + cmd = [ "git", "config", "--int", key ] >> + s = read_pipe(cmd, ignore_error=True) >> + v = s.strip() >> + try: >> + _gitConfig[key] = int(gitConfig(key, '--int')) >> + except Exception, e: > > Could do with specifying the actual type of the exception here (ValueError). Will do! Thanks!-- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html