On Thu, Sep 3, 2015 at 8:35 PM, Matthieu Moy <Matthieu.Moy@xxxxxxxxxxxxxxx> wrote: > Eric Sunshine <sunshine@xxxxxxxxxxxxxx> writes: > >> Also, if 'buf' is indeed unconditionally NUL-terminated, then the (sp >> <= buf + size) check is wasted code since the result of strstr() will >> always be either NULL or pointing somewhere within the NUL-terminated >> string. > > The null character is there, but after the signature. buf + size points > before the signature. > > Anyway, all this should go away if Karthik applies my suggestion, which > I like even more after this discussion ;-). Yes, your suggestion seems like a good way to go. -- Regards, Karthik Nayak -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html