Karthik Nayak <karthik.188@xxxxxxxxx> writes:
> On Wed, Sep 2, 2015 at 2:15 PM, Matthieu Moy
>>> @@ -754,6 +816,42 @@ static void populate_value(struct ref_array_item *ref)
>>> else
>>> v->s = " ";
>>> continue;
>>> + } else if (skip_prefix(name, "align", &valp)) {
>>> + struct align *align = &v->align;
>>> + struct strbuf **s;
>>> +
>>> + if (valp[0] != ':')
>>> + die(_("format: usage %%(align:<width>,<position>)"));
>>> + else
>>> + valp++;
>>
>> I agree with Junio that skip_prefix(name, "align:" ...) is simpler for
>> the same thing.
>
> Correct me if mistaken, but Junio wanted the first skip_prefix to
> check for "align:" rather than "align", but that would mean we don't have
> the error printing.
>
> Are you sure we want to skip that?
See my other message: you convinced me ;-).
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html