Re: [PATCH v2 0/6] Make "local" orthogonal to date format

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Sep 01, 2015 at 10:55:38PM +0100, John Keeping wrote:

> Jeff's first patch is unmodified but I've squashed the fixed currently
> on "pu" into the second.  I also realised while adding the tests that
> "raw-local" is meaningless so I've modified the code to reject it in the
> same way as "relative-local".
> 
> Jeff King (2):
>   fast-import: switch crash-report date to iso8601
>   date: make "local" orthogonal to date format
> 
> John Keeping (4):
>   t6300: introduce test_date() helper
>   t6300: make UTC and local dates different
>   t6300: add test for "raw" date format
>   t6300: add tests for "-local" date formats

Looks like we've agreed on disallowing "raw-local"[1] for the 2nd patch.
The other 4 all look good to me, with the exception of the line-wrapping
on 3/6.  Thanks for taking care of this.

-Peff

[1] I do think the error message for "relative-local is nonsense" could
    perhaps be more explanatory, but I couldn't come up with any better
    wording. But if you have ideas, feel free to switch it.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]