Re: [PATCH v2 2/6] date: make "local" orthogonal to date format

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Sep 01, 2015 at 11:33:08PM +0100, John Keeping wrote:

> > Even in --date=raw, we do show the timezone offset, so I do not
> > necessarily agree that raw-local is nonsensical.  That's the only
> > difference between the one I queued yesterday and this one.
> 
> I suspect it depends on the interpretation of "raw"; the code currently
> interprets raw to mean "exactly what exists in the commit/tag", in which
> case converting it to the local timezone is wrong.  But the
> documentation describes "raw" as "the raw Git %s %z format", and if we
> interpret it to mean "Git's internal date format" then "raw-local" makes
> sense.
> 
> The alternative would be the patch below as a preparatory step.

Ah, right, I forgot that we need to refactor show_date() to actually do
the right thing.

I think I'd be in favor of just disallowing "raw-local", then.

-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]