erik elfström <erik.elfstrom@xxxxxxxxx> writes: > On Mon, Aug 31, 2015 at 6:58 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: >> >> ... It may have been >> better if you didn't do "while we are here" and corrected only the >> &&-chain in patch 1/2 and then updated the style of the tests to >> take advantage of the newer facilities recent test-lib has in a >> separate patch 2/2, but this will do at least for now. >> >> Will queue. >> >> Thanks. > > I can do a re-roll with the chain fix in the first patch and a more > thorough modernization of t7300 in separate patches if you'd like? I > almost went this way for v1 but decided to limit the scope for the > first version. I'd say it is too much work for something that we already have reviewed and queued ;-) Let's have this patch as-is. Modernization and clean-up from time to time is a good thing to do, but we only have limited review bandwidth, so let's not overdo it. Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html