Re: [PATCH v3] git-p4: add "--path-encoding" option

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 01 Sep 2015, at 16:35, Torsten Bögershausen <tboegi@xxxxxx> wrote:

> On 2015-09-01 14.47, Lars Schneider wrote:
>>>> +test_expect_success 'Create a repo containing iso8859-1 encoded paths' '
>>>>>> +	cd "$cli" &&
>>>>>> +
>>>>>> +	ISO8859="$(printf "$UTF8_ESCAPED" | iconv -f utf-8 -t iso8859-1)" &&
>>>>>> +	>"$ISO8859" &&
>>>>>> +	p4 add "$ISO8859" &&
>>>>>> +	p4 submit -d "test commit"
>>>>>> +'
>>>> Sorry for being persistant,
>>>> but you can't create files with names that  are ISO-8859-1 encoded under Mac OS,
>>>> we end up like this:
>>>> 
>>>> a-%E4_o-%F6_u-%FC.txt
>> You are right. However, my goal is not to create a file with ISO-8859-1 characters in Mac OS. My goal is to create this file in Perforce and this approach seems to work.
>> 
>>>> 
> But this line creates a file, doesn't it ?
>> "$ISO8859" &&
> 
> (I just wonder how this works on you machine )
I tested it on OS X (HPFS) and Linux (ext4). Can you reproduce problems on your machine? If yes, what is your OS/filesystem?

> And, may be, we could fill the file with some content, to be double-sure that
> the file name conversion works with Perforce ?
> 
> like
> echo content >"$ISO8859" &&
> 
> and test the content later ?
OK, I will add this.

Thanks,
Lars

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]