On Mon, Aug 31, 2015 at 09:00:16PM +0100, John Keeping wrote: > Are you willing to resend this as a proper patch? Yup. [1/2]: fast-import: switch crash-report date to iso8601 [2/2]: date: make "local" orthogonal to date format > I'm happy to build documentation & tests on top, although there don't > seem to be any tests for date formats outside t6300-for-each-ref.sh at > the moment I've added documentation, but not tests. Tests on top would be very much appreciated. > (and the "format" mode is neither tested nor documented for > git-for-each-ref although it does work).. I think it is the opposite for testing: we test only for-each-ref. I remember when I did the original patch finding that there were no existing tests for log --date, and I was too lazy to add them. It would be nice to add some now. I agree that the documentation for for-each-ref is not up to date. I think it should do a better job of just pointing to the existing date-format (and then we do not have to keep documenting new features in two places). We could also push the content into a new file and include it from both places. But I'd be much more in favor of actually pulling the date discussion into a separate "gitdates(7)" manpage and just referencing it from both places. Even though it creates more work for a user following the reference (in manpages, at least, which are not hyperlinked), I think there is a cognitive benefit to the user in realizing that the same concept can be applied in both places. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html