On Wed, Aug 26, 2015 at 3:28 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx> writes: > >> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx> > > Because? Title just tells what the patch meant to do (i.e. instead > of returning it keeps looping), but does not say why it is a good > idea. Besides, this a no-op patch and does not make it keep looping. Because the next patch adds some post processing before returning the value. Having all the paths come to the same point would simplify the code. Will update the commit message. -- Duy -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html