On Sat, Aug 29, 2015 at 10:40 PM, Torsten Bögershausen <tboegi@xxxxxx> wrote:
> On 29.08.15 16:12, Karthik Nayak wrote:
>> diff --git a/utf8.h b/utf8.h
>> index 5a9e94b..7930b44 100644
>> --- a/utf8.h
>> +++ b/utf8.h
>> @@ -55,4 +55,19 @@ int mbs_chrlen(const char **text, size_t *remainder_p, const char *encoding);
>> */
>> int is_hfs_dotgit(const char *path);
>>
>> +typedef enum {
>> + ALIGN_LEFT,
>> + ALIGN_MIDDLE,
>> + ALIGN_RIGHT
>> +} align_type;
> should this be called strbuf_align_type ?
>
align_type seemed descriptive and unique enough.
> And is there a reason why the is in utf.c and not in stbuf.c ?
>
> (I know that there is a lot of strbuf in utf8.c, but I hadn't managed to send a patch
> to move everything into strbuf.c and make utf8.c un-aware of all strbub-business)
>
This was based on Eric's suggestions.
http://article.gmane.org/gmane.comp.version-control.git/275456
It makes sense also, since rather than acting on a strbuf, this is more of just
utilizing an strbuf to provide the result. whereas the real work is of
alignment.
--
Regards,
Karthik Nayak
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html