On Tue, Aug 25, 2015 at 11:07 PM, Matthieu Moy <Matthieu.Moy@xxxxxxxxxxxxxxx> wrote: > Christian Couder <christian.couder@xxxxxxxxx> writes: > >> Unfortunately this does not work well when a commit is created with a >> line break in the title, using for example the following command: >> >> git commit -m 'place of >> code: change we made' > > I confirm that this patch fixes the behavior for me. > > Now, I found another issue: I still have this "interpret-trailers" in my > hooks/commit-msg, and it behaves badly when I use "git commit -v". With > -v, I get a diff in COMMIT_EDITMSG, and interpret-trailers tries to > insert my Sign-off within the diff, like this: > > # Do not touch the line above. > # Everything below will be removed. > diff --git a/git-multimail/README b/git-multimail/README > index f41906b..93d4751 100644 > > Signed-off-by: Matthieu Moy <Matthieu.Moy@xxxxxxx> > --- a/git-multimail/README > +++ b/git-multimail/README > > Either commit-msg should be called after stripping the diff from > COMMIT_MSG, or interpret-trailers should learn to stop reading when the > patch starts. I think the first option is better, since it means that > any commit-msg hook does not have to deal with the patch stuff (my guess > is that there are many broken commit-msg hooks out there, but people > didn't notice because they don't use "commit -v"). > > Thanks, > It's always confused me why commit -v doesn't prepend every inserted line with "#" to mark it as a comment. Regards, Jake -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html