On Tue, Aug 25, 2015 at 12:03 PM, Jeff King <peff@xxxxxxxx> wrote: > On Tue, Aug 25, 2015 at 10:28:25AM -0700, Stefan Beller wrote: > >> By treating each object as its own task the workflow is easier to follow >> as the function used in the worker threads doesn't need any control logic >> any more. > > Have you tried running t/perf/p5302 on this? > > I seem to get a pretty consistent 2%-ish slowdown, both against git.git > and linux.git. That's not a lot, but I'm wondering if there is some > low-hanging fruit in the locking, or in the pattern of work being > dispatched. Or it may just be noise, but it seems fairly consistent. I did not run any perf tests, just the standard tests. Maybe the progress display can be moved out to another thread, such that it doesn't block the threads doing actual work. Also the progress display can be done a bit more sloppy, we are allowed to drop old events, if we have newer information. [Though this reasoning is not looking at the threading pool code, because ..um.. my code is perfect] > > -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html