Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx> writes: > I renamed both "flags" and "touched_flags" fields while making this > patch to make sure I was aware of how these flags were manipulated > (besides DIFF_OPT* macros). So hopefully I didn't miss anything. It is a bad taste to use user_defined_t typedef (I think it actually is a standard violation), isn't it? The diff-struct is not like objects where we need million copies of in-core while running. What do you need many more flags for? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html