On Tue, Aug 25, 2015 at 4:28 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Junio C Hamano <gitster@xxxxxxxxx> writes: > >> Matthieu Moy <Matthieu.Moy@xxxxxxxxxxxxxxx> writes: >> >>> Karthik Nayak <karthik.188@xxxxxxxxx> writes: >>> >>>> diff --git a/Documentation/git-for-each-ref.txt b/Documentation/git-for-each-ref.txt >>>> index 1997657..06d468e 100644 >>>> --- a/Documentation/git-for-each-ref.txt >>>> +++ b/Documentation/git-for-each-ref.txt >>>> @@ -133,7 +133,8 @@ align:: >>>> `<position>` is either left, right or middle and `<width>` is >>>> the total length of the content with alignment. If the >>>> contents length is more than the width then no alignment is >>>> - performed. >>>> + performed. If used with '--quote' everything in between %(align:..) >>>> + and %(end) is quoted. >>> >>> There's no --quote, there are --shell, --python, ... (well, actually, I >>> would have prefered to have a single --quote=language option, but that's >>> not how it is now). >>> >>> I had already commented on a preliminary version of this series >>> off-list. I think all my previous comments have been taken into account. >> >> Thanks, both. I think this is pretty close to being satisfactory >> ;-) There may probably be a handful of minor nits like the above >> that need to be addressed, but I do not think I saw anything >> glaringly wrong that makes the series unsalvageable. It was a very >> pleasant read. >> >> It's almost there, and I am very happy to see how this and other >> series evolved so far ;-) > > Having said all that, it seems that there is some trivial typo or > thinko in the formatting code to break t7004. > > Here is what I see... > > ok 98 - verifying rfc1991 signature > > expecting success: > echo "rfc1991" >gpghome/gpg.conf && > echo "rfc1991-signed-tag RFC1991 signed tag" >expect && > git tag -l -n1 rfc1991-signed-tag >actual && > test_cmp expect actual && > git tag -l -n2 rfc1991-signed-tag >actual && > test_cmp expect actual && > git tag -l -n999 rfc1991-signed-tag >actual && > test_cmp expect actual > > --- expect 2015-08-24 22:54:44.607272653 +0000 > +++ actual 2015-08-24 22:54:44.611272643 +0000 > @@ -1 +1 @@ > -rfc1991-signed-tag RFC1991 signed tag > +rfc1991-signed-tagRFC1991 signed tag > not ok 99 - list tag with rfc1991 signature > Thats weird, I just ran all tests, and nothing failed. Is this mid-way of the patch series? I tried it on the entire series and seems fine to me -- Regards, Karthik Nayak -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html