Karthik Nayak <karthik.188@xxxxxxxxx> writes: > +static void push_new_stack_element(struct ref_formatting_stack **stack) > +{ Micronit. Perhaps s/_new//;, as you do not call the other function pop_old_stack_element(). The remainder of this step looks pretty straight-forward and was a pleasant read. Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html