On Mon, Aug 24, 2015 at 10:09:41AM -0700, Junio C Hamano wrote: > So here is an solution based on the "write_file() is primarily to > produce text, so it should be able to correct the incomplete line > at the end" approach. This all looks good to me. The topics-in-flight compatibility stuff in patches 3 and 5 is neatly done. Usually I would just cheat and change the order of arguments to make the compiler notice such problems, but that's hard to do here because of the varargs (you cannot just bump "flags" to the end). -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html