Karthik Nayak <karthik.188@xxxxxxxxx> writes: > +static void end_atom_handler(struct atom_value *atomv, struct ref_formatting_state **state) > +{ > + struct ref_formatting_state *current = *state; > + if (!current->at_end) > + die(_("format: `end` atom used without a supporting atom")); You error out on %(end) without %(align), but not on %(align) without %(end). You should probably check that the stack is empty at the end and error out otherwise. -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html