Karthik Nayak <karthik.188@xxxxxxxxx> writes: > We improve the sorting option provided by 'tag.c' by using the sorting > options provided by 'ref-filter'. This causes the test 'invalid sort > parameter on command line' in t7004 to fail, as 'ref-filter' throws an > error for all sorting fields which are incorrect. The test is changed > to reflect the same. > ... > diff --git a/t/t7004-tag.sh b/t/t7004-tag.sh > index d31788c..1f066aa 100755 > --- a/t/t7004-tag.sh > +++ b/t/t7004-tag.sh > @@ -1462,13 +1462,7 @@ test_expect_success 'invalid sort parameter on command line' ' > > test_expect_success 'invalid sort parameter in configuratoin' ' > git config tag.sort "v:notvalid" && > - git tag -l "foo*" >actual && > - cat >expect <<-\EOF && > - foo1.10 > - foo1.3 > - foo1.6 > - EOF > - test_cmp expect actual > + test_must_fail git tag -l "foo*" >actual > ' You don't have to redirect the output to "actual", then. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html